Talk:CommitRules

From Gnash Project Wiki

Jump to: navigation, search

I suggest replacing 7 and 8 with a policy like:

7. No commit should prevent compiling with the most important options.

and moving most of the current 7 and 8 to notes, explaining what the important options are. OS-specific GUIs and so on (Haiku stuff) shouldn't be considered important, because most devs can't test with them, and maintaining them is the responsibility of their sponsors.

Also another suggestion:

A commit should not generate new compiler warnings.

Handling Possible Violations

I think "Fix it yourself" rule should not be first, but eventually last and only if the committer agrees with that.

In my view the process should be something like this:

1. Notify the violation by filing a bug on savannah and if possible to identify the commit introducing it with a reply on -commit 2. Allow reasonable time for a followup.... 3. If no response #if 0 4. If no response discuss on -dev

Any attempt to "Fix it yourself" would better be discussed with the committer to avoid wasting time on something which may be already fixed on a local branch

--strk 03:22, 28 May 2010 (MDT);

Compiling

"7. It is strongly recommended that a full set of build options [...] be used when making changes so you don't break compiling for packages."

I think all configurations that people want compile-tested should be enabled by default (when build requirements are satisfied).